Skip to content

fix(ci): link e2e PR summary to Playwright artifact download (#1259) - #1539

Closed
piyushbag wants to merge 1 commit into
modelcontextprotocol:v1/mainfrom
piyushbag:fix/e2e-pr-summary-artifact-url-1259
Closed

fix(ci): link e2e PR summary to Playwright artifact download (#1259)#1539
piyushbag wants to merge 1 commit into
modelcontextprotocol:v1/mainfrom
piyushbag:fix/e2e-pr-summary-artifact-url-1259

Conversation

@piyushbag

Copy link
Copy Markdown

Summary

Fix the Playwright e2e PR summary link so it downloads the uploaded HTML report artifact instead of the workflow run page.

  • Add id: playwright-report to the actions/upload-artifact@v7 step so its outputs are addressable.
  • Point daun/playwright-report-summary custom-info at ${{ steps.playwright-report.outputs.artifact-url }} (direct artifact zip URL per upload-artifact outputs).
  • Update link text to Download HTML Report + traces and drop the misleading "(download artifacts)" parenthetical.

Fixes #1259

Test plan

  • Validated .github/workflows/e2e_tests.yml parses as YAML locally.
  • CI: Playwright workflow runs on this PR; confirm the auto-posted summary link resolves to the artifact download.

Wire upload-artifact artifact-url into the playwright-report-summary
custom-info link so reviewers reach the HTML report zip directly.
@piyushbag
piyushbag force-pushed the fix/e2e-pr-summary-artifact-url-1259 branch from 08509b1 to d0a4934 Compare July 23, 2026 15:59
@cliffhall
cliffhall changed the base branch from main to v1/main July 28, 2026 03:04
@cliffhall

cliffhall commented Jul 31, 2026

Copy link
Copy Markdown
Member

Closing: v1 is deprecated.

Thank you for this contribution, and apologies for the long wait for a response.

v1 will receive security fixes only. We reviewed every open v1 PR for security impact before closing — see the backlog triage in #1819 — and a small number were retained for a final 1.0.5 patch release. This one is a functionality, compatibility, or cleanup change rather than a vulnerability fix, so it is being closed unmerged. This is not a judgment on the quality of the work — it's a consequence of the branch it targets being frozen.

If the underlying problem still exists in v2, we'd genuinely like to know. Please open an issue describing it against v2. Note that we accept external contributions as issues rather than pull requests — maintainers handle design and implementation through a prompt-driven workflow. See CONTRIBUTORS.md.

Thanks again for taking the time to contribute to the Inspector.

@cliffhall cliffhall closed this Jul 31, 2026
@cliffhall cliffhall added the closed-v1-deprecated Closed: v1 is deprecated and accepting security fixes only label Jul 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

closed-v1-deprecated Closed: v1 is deprecated and accepting security fixes only

Projects

None yet

Development

Successfully merging this pull request may close these issues.

e2e workflow: PR-summary 'View Detailed HTML Report' link points at the run page, not the artifact

2 participants